[Torch] fix external project linkage #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatPont
force-pushed
the
torch_example_fix
branch
from
0909362
to
2d0fbbc
Compare
|
wonderful, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the link with Torch when TTK is used as a library for another project such that the c++ example in TTK.
It fixes a typo
TORCH_FOUNDto@TORCH_FOUND@.Inspired by the ZFP dependency, it sets the
Torch_DIRvariable for external projects as the value used to make TTK, in order to avoid to set this variable in external projects.It also changes the c++ version of the c++ example from 14 to 17 because 17 is needed for Torch.