[MTNN] merge tree neural network refactor #1065
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatPont
force-pushed
the
mtnn_refactor
branch
from
10a87a2
to
0e2a860
Compare
MatPont
force-pushed
the
mtnn_refactor
branch
from
0e2a860
to
8b6322e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the MergeTreeAutoencoder class into different classes.
First, it separates the layer implementation to its own class.
Then, it creates a MergeTreeNeuralNetwork abstract class (that is derived by the MergeTreeAutoencoder class), serving as a template to create other kind of neural networks processing topological abstractions with the layer mentioned previously.
Finally, it adds some documentation, to all the functions of the new MergeTreeNeuralLayer and MergeTreeNeuralNetwork classes, and some explanation to how to use theses classes in other modules.