Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ttk plugin cmake install logic #919

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mwestphal
Copy link
Contributor

  • Since only the singlePlugin logic is supported now, simplyify the cmake logic
  • Remove a duplicate installation of the plugin in the bin directory

@julien-tierny
Copy link
Collaborator

hi @mwestphal
thanks a lot for your contribution!
however, it seems that this PR is breaking the continuous integration (see for instance https://github.com/topology-tool-kit/ttk/actions/runs/4668519453/jobs/8265713183?pr=919)

@julien-tierny
Copy link
Collaborator

Also, I had a quick look into this and on my systems, the plugin seems to be installed only once (here in /usr/local/bin/plugins/, which I believe is the default path where ParaView will search for plugins, if ParaView was installed in /usr/local). So I'm not so sure about the double install remark. Could you please clarify? Thanks!

LIBRARY_DESTINATION
"${CMAKE_INSTALL_BINDIR}/plugins"
"${TTK_INSTALL_PLUGIN_DIR}/${TTK_PLUGIN_SUBDIR}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with these two lines.

@mwestphal
Copy link
Contributor Author

I definitelly misunderstood something but I dont know what yet. However it looks like there multiple install cmake commands where there should be only one or none at all if handled correctly by paraview plugin mechanism.

here in /usr/local/bin/plugins/

Expected location is INSTALL_PREFIX/lib/paraview-5.11/plugins/ not bin.

The reason why I'm trying to do that is that in the paraview superbuild, ttk is installed in bin (and lib) but it should be only in lib.

I need to spend a bit more time on this and understand what it is supposed to do before I can try to fix it.

@julien-tierny julien-tierny marked this pull request as draft October 6, 2023 05:40
@julien-tierny julien-tierny added the WIP work in progress label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants