VTK FiberSurface : detect ill-formed range polygons to avoid out-of-bounds array access #954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A crash could happen when using the FiberSurface filter in Paraview, when the selected range is a point cloud and not a set of 2D cells, for example when using the tool "Select Points With Polygon" instead of "Select Cells With Polygon" (it definitely did not happen to me).
cellArray[3 * i + 1]
can then be out-of-bounds because we did not check the size of the connectivity arraycellArray
points to.With this fix, the filter returns an error in this case and does not trigger a segfault anymore.