Fix compiler warnings and 1 UB instances #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hviz Warning when building with -Wundef
|
hi @duncanspumpkin , |
duncanspumpkin
force-pushed
the
fixCompilerWarnings
branch
from
f089fbb
to
eb60566
Compare
Sure, done. It would be useful if the ci outputed the patches that it is expecting. Took me a little while to work out what it was saying was wrong. Then contributors don't need to have the same version of clang format installed (I normally only have clang format installed as part of MSVC which at present is 17.0.2) |
|
thanks a lot duncan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few little warnings and errors that i've noticed from using ttk. There are related issues for each of the commits detailing what the problem is refer to the issues for more information.