Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add events library #379

Merged
merged 1 commit into from
Oct 24, 2024
Merged

feat: add events library #379

merged 1 commit into from
Oct 24, 2024

Conversation

ieow
Copy link
Contributor

@ieow ieow commented Oct 23, 2024

Motivation and Context

Jira Link:

Description

#378
fix events dependencies

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

arch1995
arch1995 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@arch1995 arch1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti
Copy link
Member

we moved to typed-emitter and not events

chaitanyapotti
chaitanyapotti approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 8287a69 into master Oct 24, 2024
1 check passed
@chaitanyapotti chaitanyapotti deleted the feat/add-events-dep branch October 24, 2024 08:05
@chaitanyapotti chaitanyapotti mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

@arch1995 arch1995 arch1995 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ieow @chaitanyapotti @arch1995