Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing constness #49

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Fixing constness #49

merged 2 commits into from
Jan 20, 2021

Conversation

yahelnachum
Copy link
Contributor

@yahelnachum yahelnachum commented Jan 19, 2021 •
edited by mmatsa
Loading

#50

@mmatsa
Copy link
Contributor

mmatsa commented Jan 20, 2021

LGTM, except can you simultaneously in the PR:

I've already updated the README, just now, to reference version 1.0.10.

mmatsa
mmatsa approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@mmatsa mmatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the version!
LGTM

@mmatsa mmatsa merged commit 265a498 into master Jan 20, 2021
@mmatsa mmatsa deleted the fix-constness branch January 20, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatsa mmatsa mmatsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahelnachum @mmatsa