-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add float cast tensor op #2483
Open
laggui
wants to merge
10
commits into
main
Choose a base branch
from
feat/op/cast
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add float cast tensor op #2483
+597
−568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2483 +/- ##
==========================================
- Coverage 82.97% 82.85% -0.13%
==========================================
Files 812 814 +2
Lines 105212 105351 +139
==========================================
- Hits 87304 87288 -16
- Misses 17908 18063 +155 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
run-checks all
script has been executed.Changes
Add
tensor.cast(dtype)
op for floating point casting to different precision types.Currently implemented for
candle
andtch
. Had to remove the element type generic on both tensor primitives for this change.Will be implemented in a follow-up PR for:
burn-ndarray
,burn-jit
,burn-fusion
andburn-router
.Important: handling different floating point precision types in operations between multiple tensors might require automatic type promotion based on a selected strategy (e.g., cast to the higher precision type like torch). This is not in the current scope, instead backends can panic with a dtype mismatch.
Testing
Added a unit test.