-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
indexer designation #114
indexer designation #114
Conversation
Thanks for this. I'm still seeing those boolean variables (isAutoDD, isPredicatedTable, isTable, etc) in Layer.java & Layer.js. We should get rid of them, right? |
I'm temporarily keeping them to ensure backward compatibility. What is your opinion on this? |
let's get rid of them, backward compatibility isn't necessary at this point before a release 😄 |
Sure. My predicated table works fine (if you ignore that MySQL is not supported), but this line (
|
just check |
change from console.log to throw new error
cleaned up a little bit (see last commit). I'm going to do some testing and then merge |
Sure. Thank you! |
I replaced try/catch in Ideally we want smaller subroutines to throw exceptions and then catch the exceptions at higher-levels, e.g. when running Right now, there is almost no try/catch in the back-end. So part of the fix to #15 is to place try/catches in reasonable places. |
This is great! I'll pay more attention to this part |
Indexer designation by class name
fixes #113
In the compiler, usage like
layer.setIndexerType("PsqlPredicatedTableIndexer")
can be used to designate specific indexer for any layer. Backward compatibility is maintained.I gave up using
indexer
as fieldname in the compiler because the keywordtransient
will cause thegetIndexer
method which is used inboxGetter
to returnnull
. I have no idea why this would happen.Alternatively I introduced the
third_party
package and theExclude
annotation (see here for more information) to exclude fields during serialization as my discussion with @tracyhenry. I applied this for theFirstRequestHandler
, but I'm not sure if it is the only place where this annotation is needed.I tesed the indexer designation on the predicated table example.
Welcome to comment, discuss, criticise.