[#161465877] hide buy/sell button in the equity portfolio if the acco… #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt doesn't contain order capabilities
| @@ -97,6 +97,12 @@ class TradeItPortfolioEquityPositionsTableViewCell: UITableViewCell { | |||
| // MARK: private | |||
|
|
|||
| private func updateTradeButtonVisibility() { | |||
| guard let _ = self.selectedPosition?.linkedBrokerAccount.orderCapabilities(forInstrument: TradeItTradeInstrumentType.equities) else { | |||
There was a problem hiding this comment.
There is a tradeable flag in the account response we don't have in the TradeItLinkedBrokerAccount. Should we add and use this flag instead of checking the capabilities?
|
@gdebavelaere @guillaumedebavelaere Does this change just hide the trade buttons or does it also disable swipe-to-trade? |
|
@mitochondrion updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…unt doesn't contain order capabilities
https://www.pivotaltracker.com/story/show/161465877