Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove note about interrogate requiring setuptools #25

Merged
merged 1 commit into from
May 2, 2024
Merged

Remove note about interrogate requiring setuptools #25

merged 1 commit into from
May 2, 2024

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented May 2, 2024

New releases have been made and this is fixed on Python 3.12

@ekilmer
Remove note about interrogate requiring setuptools
5674383 
New releases have been made and this is fixed on Python 3.12
@ekilmer ekilmer marked this pull request as ready for review May 2, 2024 20:52
@ekilmer ekilmer requested a review from woodruffw May 2, 2024 20:52
woodruffw
woodruffw approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we should also pin interrogate to the fixed version or newer. Then again, pip should always select the newest anyways so it's not a huge deal 🙂

@woodruffw woodruffw merged commit 171716b into main May 2, 2024
4 checks passed
@woodruffw woodruffw deleted the ekilmer/remove-note branch May 2, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekilmer @woodruffw