Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds currently known publications and public use cases to the README #6572

Merged
merged 9 commits into from
Nov 27, 2024

Conversation

kaoudis
Copy link
Collaborator

@kaoudis kaoudis commented Aug 21, 2024

No description provided.

@kaoudis kaoudis requested a review from ESultanik as a code owner August 21, 2024 20:41
@kaoudis kaoudis self-assigned this Aug 22, 2024
Copy link
Collaborator

@hbrodin hbrodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just tiny nit that you might want to address.

README.md Outdated

```
```bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I guess this isn't really bash... I'd just leave it without the bash language specifier

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the trunk tool is upset if we leave it unspecified - I was kind of stumped on what to put. Looks like we can select from a few different "shell" choices; I think I'll try shell-script since that's sort of closer heh.

@kaoudis kaoudis merged commit 5542da1 into master Nov 27, 2024
7 checks passed
@kaoudis kaoudis deleted the kaoudis/readme-update branch November 27, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants