Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl: stream into sha256 #15

Merged
merged 3 commits into from
May 14, 2024
Merged

impl: stream into sha256 #15

merged 3 commits into from
May 14, 2024

Conversation

woodruffw
Copy link
Member

This avoids the need to buffer the entire input in memory.

Closes #13.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw added the enhancement ✨ New feature or request label May 13, 2024
@woodruffw woodruffw requested a review from facutuesca May 13, 2024 18:37
@woodruffw woodruffw self-assigned this May 13, 2024
woodruffw and others added 2 commits May 13, 2024 14:40
Signed-off-by: William Woodruff <william@trailofbits.com>
Copy link
Collaborator

@facutuesca facutuesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @woodruffw !

@facutuesca facutuesca merged commit cab35a5 into main May 14, 2024
6 checks passed
@facutuesca facutuesca deleted the ww/streaming branch May 14, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttestationPayload.from_dist should probably do SHA256 in a streaming fashion
2 participants