Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent third party exceptions to leak from Attestation.sign. #28

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Prevent third party exceptions to leak from Attestation.sign. #28

merged 5 commits into from
Jul 9, 2024

Conversation

DarkaMaul
Copy link
Collaborator

Fixes #23

@DarkaMaul DarkaMaul marked this pull request as ready for review July 2, 2024 09:10
@DarkaMaul DarkaMaul requested review from facutuesca and woodruffw July 2, 2024 09:10
woodruffw
woodruffw reviewed Jul 2, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
woodruffw
woodruffw approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DarkaMaul, looks good!

@woodruffw woodruffw merged commit fb8c11d into main Jul 9, 2024
6 checks passed
@woodruffw woodruffw deleted the dm/third-party-exceptions branch July 9, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

@facutuesca facutuesca Awaiting requested review from facutuesca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API: Attestation.sign should not leak 3p exceptions
2 participants
@DarkaMaul @woodruffw