Run mypy on tests #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to use Pydantic's model APIs directly, instead of going through a `TypeAdapter`. This changeset also enables typechecking on our unit tests. Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
|
Are we sure we want to follow this road? from pydantic import Field, TypeAdapter, RootModel
from typing import Annotated
from pypi_attestations import GitHubPublisher, GitLabPublisher
gh_raw = {"kind": "GitHub", "repository": "foo/bar", "workflow": "publish.yml"}
P_before = Annotated[GitHubPublisher | GitLabPublisher, Field(discriminator="kind")]
P_after = RootModel[Annotated[GitHubPublisher | GitLabPublisher, Field(discriminator='kind')]]
assert isinstance(TypeAdapter(P_before).validate_python(gh_raw), GitHubPublisher) # True
assert isinstance(P_after.model_validate(gh_raw), GitHubPublisher) # FalseIMO, using |
DarkaMaul
reviewed
Aug 14, 2024
Yeah, I have mixed feelings about it -- on one hand IMO it makes the types more uniform here, but the need for There are other beneficial changes in this PR, so I'll remove the |
Co-authored-by: dm <alexis.challande@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use Pydantic's model APIs directly, instead of going through aTypeAdapter.This changeset also enables typechecking on our unit tests.