remove Verifier param from verify() API #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a foreign type by instead constructing the Verifier under the hood within verify(). Signed-off-by: William Woodruff <william@trailofbits.com>
Open
WIP. Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
facutuesca
reviewed
Oct 11, 2024
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
facutuesca
reviewed
Oct 15, 2024
Co-authored-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
facutuesca
approved these changes
Oct 22, 2024
src/pypi_attestations/_impl.py
Outdated
| policies: list[VerificationPolicy] = [ | ||
| policy.OIDCIssuerV2("https://token.actions.githubusercontent.com"), | ||
| policy.OIDCSourceRepositoryURI(f"https://github.com/{self.repository}"), | ||
| _GitHubTrustedPublisherPolicy(self.repository, self.workflow), |
There was a problem hiding this comment.
nit: the name _GitHubTrustedPublisherPolicy suggests that it's, by itself, the full policy for GitHub. Maybe we could rename it to something like _GitHubBuildConfigURIPolicy?
Or alternatively, make _GitHubTrustedPublisherPolicy return the full AllOf(OIDCIssuer,OIDCSourceRep,...) policy?
There was a problem hiding this comment.
Ah yeah, good idea -- I'll make it contain the AllOf internally.
Signed-off-by: William Woodruff <william@trailofbits.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP;See #55 (comment) for motivating context.This removes a foreign type by instead constructing the Verifier under the hood within verify().
Key changes:
Attestation.verify()now constructs the verifier internally, based on thestagingkwarg.Attestation.verify()can now takePublishers, which are converted into their appropriate policies under the hood. Policies can also still be passed in directly.Publishervariants now have_as_policy(), which is a private API for the publisher to verification policy transform.This will hopefully make things easier for downstream users, particularly people who are pulling provenance objects from PyPI via PEP 740 and trying to verify them (but are getting stuck on the transforms between the "PEP 740" and "Sigstore" views).