Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitLabPublisher workflow path check #71

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

facutuesca
Copy link
Collaborator

Now it behaves like GitHub's publisher: ref and sha claims are extracted from the attestation's certificate extensions, and the workflow file path must be passed during construction.

@facutuesca facutuesca requested a review from woodruffw November 19, 2024 21:21
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
@facutuesca facutuesca force-pushed the ft/fix-gitlab-publisher branch from 7cbe404 to 79eea19 Compare November 19, 2024 21:22
Co-authored-by: William Woodruff <william@trailofbits.com>
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@woodruffw woodruffw merged commit d684a65 into main Nov 19, 2024
7 checks passed
@woodruffw woodruffw deleted the ft/fix-gitlab-publisher branch November 19, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants