Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: fix typo, OwnedMessageImprint is owned by PyBytes #3

Merged
merged 14 commits into from
Oct 2, 2024
Merged

rust: fix typo, OwnedMessageImprint is owned by PyBytes #3

merged 14 commits into from
Oct 2, 2024

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Oct 1, 2024 •
edited
Loading

WIP.

@woodruffw
rust: fix typo, OwnedMessageImprint is owned by PyBytes
5c73b80 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
fix PyTSTInfo::message_imprint
14e1c5b 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
rust: remove unnecessary unwraps
5874af1 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw marked this pull request as ready for review October 1, 2024 16:47
@woodruffw
remove some Arcs
11f3bc5 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Member Author

11f3bc5 changes OwnedSignedData and OwnedTSTInfo to be owned by a backing PyBytes, rather than an Arc'd OwnedTimeStampResp -- this saves us some reference counting at the cost of a bit of re-parsing (which is fine, since rust-asn1 is quite fast). That in turn could probably be avoided by making the parsing of PyTSTInfo and SignedData 'eager' into TimeStampResp.

@woodruffw
remove the last Arc
3b2607f 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
disable cache
85133f9 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
lintage
094255d 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
disable caching, proper matrix
86d36e4 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
allow prereleases in CI
aaaafb9 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw requested a review from DarkaMaul October 1, 2024 18:58
woodruffw and others added 5 commits October 1, 2024 17:09
@woodruffw
tsp-asn1: clean up docs a bit
8c3c49e 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
run tsp-asn1 tests
839c5dd 
Signed-off-by: William Woodruff <william@trailofbits.com>
@DarkaMaul
Update Cargo.toml
58fd2e4
@DarkaMaul
Fix typo in doc string
d4f3734
@DarkaMaul
Update workflows
739b400
@DarkaMaul
Copy link
Collaborator

Thanks a lot @woodruffw !

@DarkaMaul DarkaMaul merged commit 6ad600e into main Oct 2, 2024
22 checks passed
@DarkaMaul DarkaMaul deleted the ww/ownership branch October 2, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkaMaul DarkaMaul Awaiting requested review from DarkaMaul DarkaMaul is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woodruffw @DarkaMaul