Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on maturin #88

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Remove dependency on maturin #88

merged 2 commits into from
Dec 11, 2024

Conversation

DarkaMaul
Copy link
Collaborator

Fixes #86

We keep it in dev target because we want to be able to run make dev

@mgorny
Copy link

mgorny commented Dec 11, 2024

Thanks!

facutuesca
facutuesca approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@facutuesca facutuesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DarkaMaul DarkaMaul merged commit a31282d into main Dec 11, 2024
34 checks passed
@DarkaMaul DarkaMaul deleted the dm/remove-maturin branch December 11, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facutuesca facutuesca facutuesca approved these changes

@woodruffw woodruffw Awaiting requested review from woodruffw woodruffw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect runtime dependency on maturin
3 participants
@DarkaMaul @mgorny @facutuesca