Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running test on PyPy #89

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Fix running test on PyPy #89

merged 5 commits into from
Dec 11, 2024

Conversation

DarkaMaul
Copy link
Collaborator

@DarkaMaul DarkaMaul commented Dec 11, 2024 •
edited
Loading

Fixes #87

Tasks:

  • Exclude tests when running on PyPy
  • [ ] Correctly link with libpypy3.XX-c.dylib when using cargo test ( e.g., by using DYLD_LIBRARY_PATH) on MacOS
  • Update CI to test with PyPY
  • Add a changelog entry

@DarkaMaul
Copy link
Collaborator Author

Locally, I need to use DYLD_FALLBACK_LIBRARY_PATH and point it towards my uv python dir installation of pypy to make it work. [1]

However, the CI works fine without any workaround.

[1]: DYLD_FALLBACK_LIBRARY_PATH=$(uv python dir)/pypy-3.10.14-macos-aarch64-none/bin cargo test

@DarkaMaul DarkaMaul marked this pull request as ready for review December 11, 2024 13:50
@woodruffw woodruffw merged commit 52e9b54 into main Dec 11, 2024
36 checks passed
@woodruffw woodruffw deleted the dm/fix-pypy branch December 11, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

@facutuesca facutuesca Awaiting requested review from facutuesca facutuesca is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo test fails to compile with PyPy3
2 participants
@DarkaMaul @woodruffw