treewide: Silence gcc warnings.

trailofbits · May 16, 2023 · d1e375f · d1e375f
1 parent 366d642
commit d1e375f
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 5 deletions.
diff --git a/lib/vast/Dialect/HighLevel/HighLevelLinkage.cpp b/lib/vast/Dialect/HighLevel/HighLevelLinkage.cpp
@@ -250,7 +250,7 @@ namespace vast::hl {
         auto &actx = decl->getASTContext();
         auto linkage = actx.GetGVALinkageForFunction(decl);
 
-        if (const auto *dtor = clang::dyn_cast< clang::CXXDestructorDecl >(decl)) {
+        if (/*const auto *dtor =*/ clang::dyn_cast< clang::CXXDestructorDecl >(decl)) {
             VAST_UNIMPLEMENTED;
         }
 

diff --git a/lib/vast/Frontend/GenAction.cpp b/lib/vast/Frontend/GenAction.cpp
@@ -183,6 +183,7 @@ namespace vast::cc {
                 case target_dialect::low_level: return "low_level";
                 case target_dialect::llvm: return "llvm";
             }
+            VAST_UNREACHABLE("Unknown target dialect to string.");
         }
 
         void compile_via_vast(auto mod, mcontext_t *mctx)

diff --git a/lib/vast/Translation/CodeGenDriver.cpp b/lib/vast/Translation/CodeGenDriver.cpp
@@ -236,7 +236,7 @@ namespace vast::cg
                 VAST_UNIMPLEMENTED_MSG("codegen for multi version function");
             }
 
-            if (const auto *method = llvm::dyn_cast< clang::CXXMethodDecl >(decl)) {
+            if (/*const auto *method =*/ llvm::dyn_cast< clang::CXXMethodDecl >(decl)) {
                 VAST_UNIMPLEMENTED_MSG("cxx methods");
             }
 

diff --git a/lib/vast/Translation/CodeGenFunction.cpp b/lib/vast/Translation/CodeGenFunction.cpp
@@ -74,7 +74,7 @@ namespace vast::cg
     bool codegen_driver::may_drop_function_return(qual_type rty) const {
         // We can't just disard the return value for a record type with a complex
         // destructor or a non-trivially copyable type.
-        if (const auto *recorrd_type = rty.getCanonicalType()->getAs< clang::RecordType >()) {
+        if (/*const auto *record_type =*/ rty.getCanonicalType()->getAs< clang::RecordType >()) {
             VAST_UNIMPLEMENTED;
         }
 

diff --git a/lib/vast/Translation/CodeGenStmtVisitor.cpp b/lib/vast/Translation/CodeGenStmtVisitor.cpp
@@ -104,6 +104,7 @@ namespace vast::hl
             case clang::PredefinedExpr::IdentKind::PrettyFunctionNoVirtual :
                 return IdentKind::PrettyFunctionNoVirtual;
         }
+        VAST_UNREACHABLE( "unsupported ident kind" );
     }
 
 } // namespace vast::hl
diff --git a/lib/vast/Translation/Mangler.cpp b/lib/vast/Translation/Mangler.cpp
@@ -11,7 +11,7 @@ namespace vast::cg
 
         // Some ABIs don't have constructor variants. Make sure that base and complete
         // constructors get mangled the same.
-        if (const auto *ctor = clang::dyn_cast< clang::CXXConstructorDecl >(canonical.getDecl())) {
+        if (/*const auto *ctor =*/ clang::dyn_cast< clang::CXXConstructorDecl >(canonical.getDecl())) {
             VAST_UNIMPLEMENTED_IF(!target_info.getCXXABI().hasConstructorVariants());
         }
 

diff --git a/tools/vast-repl/vast-repl.cpp b/tools/vast-repl/vast-repl.cpp
@@ -57,7 +57,7 @@ namespace vast::repl
 
             while (!cli.exit()) {
                 std::string cmd;
-                if (auto quit = linenoise::Readline("> ", cmd)) {
+                if (linenoise::Readline("> ", cmd)) {
                     break;
                 }