Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the tower component. #628

Merged
merged 34 commits into from
Jul 11, 2024
Merged

Expand the tower component. #628

merged 34 commits into from
Jul 11, 2024

Conversation

lkorenc
Copy link
Contributor

@lkorenc lkorenc commented Jun 20, 2024

No description provided.

xlauko
xlauko reviewed Jun 27, 2024
View reviewed changes
include/vast/Tower/Handle.hpp Show resolved Hide resolved
include/vast/Tower/Link.hpp Outdated Show resolved Hide resolved
include/vast/Tower/Link.hpp Outdated Show resolved Hide resolved
include/vast/Tower/Link.hpp Outdated Show resolved Hide resolved
include/vast/Tower/Link.hpp Outdated Show resolved Hide resolved
lib/vast/Tower/Link.cpp Outdated Show resolved Hide resolved
lib/vast/Tower/Link.cpp Outdated Show resolved Hide resolved
lib/vast/Tower/LocationInfo.cpp Outdated Show resolved Hide resolved
lib/vast/Tower/LocationInfo.cpp Outdated Show resolved Hide resolved
lib/vast/Tower/LocationInfo.cpp Outdated Show resolved Hide resolved
@xlauko xlauko added the mlir label Jul 9, 2024
xlauko
xlauko reviewed Jul 9, 2024
View reviewed changes
include/vast/Tower/Link.hpp Outdated Show resolved Hide resolved
include/vast/Tower/Storage.hpp Outdated Show resolved Hide resolved
include/vast/Tower/Tower.hpp Outdated Show resolved Hide resolved
include/vast/repl/state.hpp Outdated Show resolved Hide resolved
lib/vast/Tower/Link.cpp Outdated Show resolved Hide resolved
lib/vast/Tower/Link.cpp Outdated Show resolved Hide resolved
lib/vast/Tower/Link.cpp Outdated Show resolved Hide resolved
lib/vast/Tower/Link.cpp Outdated Show resolved Hide resolved
lib/vast/Tower/LocationInfo.cpp Show resolved Hide resolved
lib/vast/Tower/LocationInfo.cpp Outdated Show resolved Hide resolved
@lkorenc lkorenc marked this pull request as ready for review July 9, 2024 12:35
@lkorenc lkorenc added the tower label Jul 9, 2024
@lkorenc lkorenc force-pushed the tower branch 2 times, most recently from 7566752 to a9f6678 Compare July 10, 2024 10:13
lkorenc added 18 commits July 11, 2024 18:22
@lkorenc
tower: Fix inconsistent local type aliases.
12c1e00
@lkorenc
tower: Add draft of more fine-grained location making api.
910b62e
@lkorenc
tower: Pull tower::handle_t into ::vast::tw namespace.
f1615ee
@lkorenc
tower: Introduce core components.
640ece1
@lkorenc
tower: Add make_root function.
5a15106
@lkorenc
tower: Gut original tower struct to leave space for new impl.
d8ebaeb
@lkorenc
tower: Fix prototype of location_maker::get_next.
18dd4d0
@lkorenc
tower: Make ctor of tower public.
4189e2b
@lkorenc
repl: Mock basic initialization and usage of tower on mlir module c…
20c6099 
…reation.
@lkorenc
tower: Initial prototype that produces one link.
b31bcd3
@lkorenc
tower: Add link_interface::[from,to] methods.
e0d80fd
@lkorenc
repl: Add support for show link command.
5025537
@lkorenc
repl: Allow storage of multiple links.
6ef6bd5
@lkorenc
repl: Add support for link rendering.
86d816e
@lkorenc
tower: Rename location_info to location_info_t.
b63a305
@lkorenc
tower: Simplify new location creation.
4ff86ca
@lkorenc
tower: Modernize parts of the code with newer ranges and views api.
5abec68
@lkorenc
tower: Fix typos.
641a429
lkorenc added 16 commits July 11, 2024 18:24
@lkorenc
tower: Replace VAST_UNREACHABLE with VAST_UNIMPLEMENTED.
d12f627
@lkorenc
tower: Unify naming conventions in location_info_t.
1086463
@lkorenc
tower: Remove shared_[children,parents] from link_interface.
2d1529a
@lkorenc
tower: Rename one_step_link_interface::li() to location_info().
a8297a8
@lkorenc
tower: Steps between conversions are now modeled as link_interface.
9eb4b6f
@lkorenc
tower: Improve naming of some functions.
a515566
@lkorenc
tower: Unify all link apis to refer to child[ren]/parent[s].
dae882e
@lkorenc
tower: Add std::move to avoid extra copies.
0175cc4
@lkorenc
tower: Change type of module_storage::storage to llvm::DenseMap.
9d6eeca
@lkorenc
tower: Change type of op_mapping to llvm::DenseMap.
2c7a0e5
@lkorenc
tower: Add views helpers.
48ed305
@lkorenc
repl: Adapt to newer tower API.
40df479
@lkorenc
tower: Remove default_tower type alias.
2009fc7
@lkorenc
tower: Remove std::ranges and views usage as they are unsupported…
bc2fa39 
… in CI.
@lkorenc
test:repl: Update test to reflect changes in driver.
42b8443
@lkorenc
test:repl: Disable raise.c due to unresolved problem (Issue #668).
0dde807
@github-actions GitHub Actions
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 7 file(s) not formatted
  • include/vast/Tower/Link.hpp
  • include/vast/Tower/Storage.hpp
  • include/vast/repl/command.hpp
  • lib/vast/Tower/Link.cpp
  • lib/vast/Tower/LocationInfo.cpp
  • tools/vast-repl/command.cpp
  • tools/vast-repl/state.cpp

Have any feedback or feature suggestions? Share it here.

@lkorenc lkorenc requested a review from xlauko July 11, 2024 16:35
@lkorenc lkorenc merged commit 1096a53 into master Jul 11, 2024
8 checks passed
@lkorenc lkorenc deleted the tower branch July 11, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlauko xlauko xlauko approved these changes

Assignees

@lkorenc lkorenc

Labels
mlir tower
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkorenc @xlauko