Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve global variable lowering #736

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Improve global variable lowering #736

merged 4 commits into from
Oct 15, 2024

Conversation

Jezurko
Copy link
Collaborator

@Jezurko Jezurko commented Oct 9, 2024 •
edited
Loading

  • Add const to hl vardecl and propagate it to llvm globals
  • Zero init variables with static storage duration, if they do not have initializer

@Jezurko Jezurko self-assigned this Oct 9, 2024
@Jezurko Jezurko changed the title Propagate constness of global variables to llvm and add default zero init to variables with static duration Improve global variable lowering Oct 9, 2024
@Jezurko Jezurko marked this pull request as ready for review October 14, 2024 20:36
@Jezurko Jezurko requested a review from xlauko as a code owner October 14, 2024 20:36
@github-actions GitHub Actions
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v19.1.1) reports: 1 file(s) not formatted
  • lib/vast/Conversion/ToLLVM/IRsToLLVM.cpp

Have any feedback or feature suggestions? Share it here.

@xlauko xlauko merged commit 673e201 into master Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlauko xlauko xlauko approved these changes

Assignees

@Jezurko Jezurko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jezurko @xlauko