Add AtomicExpr stub

include/vast/CodeGen/DefaultStmtVisitor.hpp

@@ -204,7 +204,7 @@ namespace vast::cg {
         operation VisitArraySubscriptExpr(const clang::ArraySubscriptExpr *expr);
         // operation VisitArrayTypeTraitExpr(const clang::ArrayTypeTraitExpr *expr)
         // operation VisitAsTypeExpr(const clang::AsTypeExpr *expr)
-        // operation VisitAtomicExpr(const clang::AtomicExpr *expr)
+        operation VisitAtomicExpr(const clang::AtomicExpr *expr);
         // operation VisitBlockExpr(const clang::BlockExpr *expr)
 
         // operation VisitCXXBindTemporaryExpr(const clang::CXXBindTemporaryExpr *expr);

include/vast/Dialect/HighLevel/HighLevelOps.td

@@ -1759,4 +1759,26 @@ def HighLevel_GenericSelectionExpr
   let assemblyFormat = [{ attr-dict `match` (`region` `:` $control^)? (`type` `:` $controlType^)? $body `->` type($result)}];
 }
 
+def HighLevel_AtomicExpr
+  : HighLevel_Op< "atomic_expr", [NoTerminator] >
+  , Arguments<(ins StrAttr:$name)>
+  , Results<(outs Optional< AnyType >:$result)>
+{
+    let summary = "VAST atomic expr";
+    let description = [{ VAST atomic expr stub}];
+
+    let regions = (region VariadicRegion< AnyRegion >:$subexprs);
+
+    let skipDefaultBuilders = 1;
+    let builders = [
+        OpBuilder<(ins
+            "llvm::StringRef":$name,
+            "Type":$rty,
+            "const std::vector< builder_callback > &":$builders
+        )>
+    ];
+
+    let assemblyFormat = [{ $name attr-dict `:` type($result) $subexprs}];
+}
+
 #endif // VAST_DIALECT_HIGHLEVEL_IR_HIGHLEVELOPS

lib/vast/CodeGen/DefaultStmtVisitor.cpp

@@ -1,4 +1,4 @@
 // Copyright (c) 2022-present, Trail of Bits, Inc.
 
 #include "vast/Util/Warnings.hpp"
 
@@ -930,7 +930,19 @@
 
     // operation default_stmt_visitor::VisitArrayTypeTraitExpr(const clang::ArrayTypeTraitExpr *expr)
     // operation default_stmt_visitor::VisitAsTypeExpr(const clang::AsTypeExpr *expr)
-    // operation default_stmt_visitor::VisitAtomicExpr(const clang::AtomicExpr *expr)
+    operation default_stmt_visitor::VisitAtomicExpr(const clang::AtomicExpr *expr) {
+        std::vector< builder_callback > subexprs;
+        for (auto subexpr : expr->children()) {
+            subexprs.push_back(mk_region_builder(subexpr));
+        }
+        return bld.compose< hl::AtomicExpr >()
+            .bind(self.location(expr))
+            .bind(expr->getOpAsString())
+            .bind(visit_maybe_lvalue_result_type(expr))
+            .bind(subexprs)
+            .freeze();
+
+    }
     // operation default_stmt_visitor::VisitBlockExpr(const clang::BlockExpr *expr)
 
     // operation default_stmt_visitor::VisitCXXBindTemporaryExpr(const clang::CXXBindTemporaryExpr *expr) { return {}; }

lib/vast/Dialect/HighLevel/HighLevelOps.cpp

@@ -1,4 +1,4 @@
 // Copyright (c) 2021-present, Trail of Bits, Inc.
 
 #include "vast/Util/Warnings.hpp"
 
@@ -886,6 +886,24 @@
     bool GenericSelectionExpr::isTypePredicate() {
         return (*this)->hasAttr("matchType");
     }
+
+    //
+    // AtomicExpr
+    //
+
+    void AtomicExpr::build(
+        Builder &bld,
+        State &st,
+        llvm::StringRef name,
+        mlir_type type,
+        const std::vector< builder_callback > &builders
+    ) {
+        InsertionGuard guard(bld);
+        st.addAttribute(getNameAttrName(st.name), bld.getStringAttr(name));
+        st.addTypes(type);
+        for (builder_callback_ref builder : builders)
+            build_region(bld, st, builder);
+    }
 }
 
 //===----------------------------------------------------------------------===//

test/vast/Dialect/Unsupported/atomicexpr.cpp → test/vast/Dialect/HighLevel/atomicexpr.cpp

@@ -2,7 +2,7 @@
 // RUN: %vast-front %s -vast-emit-mlir=hl -o - > %t && %vast-opt %t | diff -B %t -
 
 int load(int* p) {
-    // CHECK: unsup.stmt "AtomicExpr"
+    // CHECK: hl.atomic_expr "__atomic_load_n" : !hl.int
     // CHECK: hl.ref @p
     // CHECK: hl.const #core.integer<5>
     int q = __atomic_load_n (p, __ATOMIC_SEQ_CST);