Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue replacement of TableMeta with ColumnSchema and Logical Types #85

Merged
merged 9 commits into from
Jul 4, 2023

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jul 4, 2023

No description provided.

@gsheni gsheni self-assigned this Jul 4, 2023
@gsheni gsheni marked this pull request as ready for review July 4, 2023 17:36
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 91.58% and project coverage change: +3.86 🎉

Comparison is base (ff2f3ee) 65.70% compared to head (3cae3cd) 69.56%.

❗ Current head 3cae3cd differs from pull request most recent head 0e92094. Consider uploading reports for the commit 0e92094 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   65.70%   69.56%   +3.86%     
==========================================
  Files          20       23       +3     
  Lines         866      930      +64     
==========================================
+ Hits          569      647      +78     
+ Misses        297      283      -14     
Impacted Files Coverage Δ
trane/column_schema.py 84.61% <84.61%> (ø)
trane/logical_types.py 90.47% <90.47%> (ø)
trane/core/utils.py 95.00% <95.00%> (ø)
trane/__init__.py 100.00% <100.00%> (ø)
trane/core/prediction_problem.py 58.15% <100.00%> (+8.15%) ⬆️
trane/core/prediction_problem_generator.py 76.19% <100.00%> (+0.22%) ⬆️
trane/datasets/load_functions.py 91.30% <100.00%> (ø)
trane/ops/aggregation_ops.py 100.00% <100.00%> (+10.28%) ⬆️
trane/ops/filter_ops.py 83.33% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gsheni gsheni merged commit d9c37d9 into main Jul 4, 2023
9 checks passed
@gsheni gsheni deleted the clean_up_ops branch July 4, 2023 17:59
@gsheni gsheni restored the clean_up_ops branch July 6, 2023 21:21
@gsheni gsheni deleted the clean_up_ops branch July 6, 2023 21:21
@gsheni gsheni mentioned this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant