fix: minor fixes

transform1234 · Sep 14, 2023 · 3d2909d · 3d2909d
1 parent a5d3d21
commit 3d2909d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 15 deletions.
diff --git a/src/adapters/hasura/altStudent.adapter.ts b/src/adapters/hasura/altStudent.adapter.ts
@@ -4,14 +4,14 @@ import jwt_decode from "jwt-decode";
 import { SuccessResponse } from "src/success-response";
 import { StudentDto } from "src/altStudent/dto/alt-student.dto";
 import { ErrorResponse } from "src/error-response";
-import { HasuraUserService } from "./user.adapter";
 import { getUserRole } from "./adapter.utils";
+import { ALTHasuraUserService } from "./altUser.adapter";
 
 @Injectable()
 export class ALTStudentService {
   constructor(
     private httpService: HttpService,
-    private userService: HasuraUserService
+    private userService: ALTHasuraUserService
   ) {}
 
   baseURL = process.env.ALTHASURA;

diff --git a/src/adapters/hasura/altUser.adapter.ts b/src/adapters/hasura/altUser.adapter.ts
@@ -119,12 +119,7 @@ export class ALTHasuraUserService {
     }
 
     Object.keys(userDto).forEach((e) => {
-      if (
-        userDto[e] &&
-        userDto[e] !== "" &&
-        e != "password" &&
-        Object.keys(userSchema).includes(e)
-      ) {
+      if (e != "password" && Object.keys(userSchema).includes(e)) {
         if (e === "role") {
           query += `${e}: ${userDto[e]},`;
         } else if (Array.isArray(userDto[e])) {
@@ -190,11 +185,7 @@ export class ALTHasuraUserService {
     const userSchema = new UserUpdateDto(userUpdateDto);
     let userUpdate = "";
     Object.keys(userUpdateDto).forEach((e) => {
-      if (
-        userUpdateDto[e] &&
-        userUpdateDto[e] != "" &&
-        Object.keys(userSchema).includes(e)
-      ) {
+      if (Object.keys(userSchema).includes(e)) {
         if (e === "role") {
           userUpdate += `${e}: ${userUpdateDto[e]},`;
         } else if (Array.isArray(userUpdateDto[e])) {

diff --git a/src/altStudent/altStudent.module.ts b/src/altStudent/altStudent.module.ts
@@ -2,7 +2,7 @@ import { CacheModule, Module } from "@nestjs/common";
 import { HttpModule } from "@nestjs/axios";
 import { ALTStudentController } from "./altStudent.controller";
 import { ALTStudentService } from "src/adapters/hasura/altStudent.adapter";
-import { HasuraUserService } from "src/adapters/hasura/user.adapter";
+import { ALTHasuraUserService } from "src/adapters/hasura/altUser.adapter";
 
 const ttl = process.env.TTL as never;
 
@@ -14,6 +14,6 @@ const ttl = process.env.TTL as never;
     }),
   ],
   controllers: [ALTStudentController],
-  providers: [ALTStudentService, HasuraUserService],
+  providers: [ALTStudentService, ALTHasuraUserService],
 })
 export class ALTStudentModule {}