Add invalid_tls_certificate tag #1050
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with this tag, although this tag should honestly be automated (no idea how) |
|
Automating it is risky because a certificate might be invalid for malicious reasons |
|
Good point. That was my only concern for this idea.
Message ID: ***@***.***>
… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, I'm proposing to add such a tag.
I know that at the moment transitland has no use of it, but I think the starting point is adding the tag :).
Also, transitland-atlas is being used by many other project as a data repo, so I think this would still make sense even if for the foreseeable future transitland itself is not able to use it.