Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/companion: do not use unsafe call to JSON.stringify #5422

Merged
merged 2 commits into from
Aug 29, 2024
Merged

@uppy/companion: do not use unsafe call to JSON.stringify #5422

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2507ca1
@uppy/companion: do not use unsafe call to `JSON.stringify`
aduh95 Aug 21, 2024
57dde7d
fixup
aduh95 Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/@uppy/companion/src/server/emitter/redis-emitter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const { EventEmitter } = require('node:events')
const util = require('node:util')

const logger = require('../logger')

Expand Down Expand Up @@ -141,7 +142,7 @@ module.exports = (redisClient, redisPubSubScope) => {
* @param {string} eventName name of the event
*/
function emit (eventName, ...args) {
runWhenConnected(() => publisher.publish(getPrefixedEventName(eventName), JSON.stringify(args)))
runWhenConnected(() => publisher.publish(getPrefixedEventName(eventName), util.inspect(args)))
}

/**
Expand Down
Loading