Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Next.js docs #5502

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Add Next.js docs #5502

merged 4 commits into from
Nov 18, 2024

Conversation

Murderlon
Copy link
Member

Closes #1958

@Murderlon Murderlon self-assigned this Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Diff output files
No diff

@Murderlon Murderlon requested a review from kvz November 7, 2024 13:58
Copy link
Member

@kvz kvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work Merlijn! Left a few nits/Qs

can be a security risk**. Signature Authentication is a security measure that
can prevent outsiders from tampering with your Assembly Instructions.

Generating a signature should be done on the server to avoid leaking secrets.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Generating a signature should be done on the server to avoid leaking secrets.
Generating a signature should be done on the server to avoid leaking secrets. The signature itself can then be freely passed around as proof that whoever generated it, had the secrets only known to Transloadit and you as a customer. It is only valid for the instructions and time duration that the signature was generated for.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I linked to the resource already as this text is already getting too long imo

docs/framework-integrations/nextjs.mdx Outdated Show resolved Hide resolved
docs/framework-integrations/nextjs.mdx Show resolved Hide resolved
import '@uppy/dashboard/dist/style.min.css';

function createUppy() {
return new Uppy().use(Tus, { endpoint: '/api/upload' });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're using tabs for indentation, if we switch to tabs it should be across the board i think, not just this doc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all auto formatted so should be inline with everything else.

docs/framework-integrations/nextjs.mdx Outdated Show resolved Hide resolved
docs/framework-integrations/nextjs.mdx Show resolved Hide resolved
docs/framework-integrations/nextjs.mdx Show resolved Hide resolved
docs/framework-integrations/nextjs.mdx Outdated Show resolved Hide resolved
docs/framework-integrations/nextjs.mdx Outdated Show resolved Hide resolved
docs/framework-integrations/nextjs.mdx Outdated Show resolved Hide resolved
@Murderlon Murderlon merged commit ae9ab2f into main Nov 18, 2024
17 checks passed
@Murderlon Murderlon deleted the nextjs-docs branch November 18, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NextJS example
2 participants