Fix broken lint on CI #5507
Merged
Fix broken lint on CI #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i'm currently getting errors with yarn lint locally, but CI is succeeding. meaning i always have to bypass commit hooks Unable to resolve path to module '@uppy/...' import/no-unresolved
|
Prettier failing currently |
|
yes, and lint is still succeeding 🤔 ima try more things |
|
wow i found the culprit Line 58 in 437aecd |
|
to heck with it. i'll just disable the rule. i don't think it's very necessary now that we have typescript (which should also error if the import cannot be resolved, right?) |
i don't think it's very necessary now that we have typescript
Diff output filesNo diff |
Murderlon
reviewed
Nov 11, 2024
| @@ -25,22 +26,12 @@ jobs: | |||
| steps: | |||
| - name: Checkout sources | |||
| uses: actions/checkout@v4 | |||
| - name: Get yarn cache directory path | |||
There was a problem hiding this comment.
Because the setup-node action supports caching built in, so we can remove all this
Murderlon
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i'm currently getting errors with yarn lint locally, but CI is succeeding. meaning i always have to bypass commit hooks: