Merge pull request #2 from transprime-research/bugfix/prevent-executi…

…ng-function-call-on-first-data-string Prevent string function call on first piped data
transprime-research · Apr 29, 2020 · c9dde00 · c9dde00
2 parents ed5afe6 + b20d31a
commit c9dde00
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/Piper.php b/src/Piper.php
@@ -52,7 +52,7 @@ public function up(callable $action = null)
 
         $result = $this->piped[0];
 
-        if (is_callable($result)) {
+        if (is_callable($result) && !is_string($result)) {
             $result = $result();
         }
 

diff --git a/tests/PiperTest.php b/tests/PiperTest.php
@@ -161,6 +161,16 @@ public function testPiperOnStaticCreation()
                 ->up()
         );
     }
+
+    public function testStringPassedIntoFirstPipeShouldBeTreatedAsString()
+    {
+        $this->assertEquals(
+            'STRMANIPULATOR::STRTOLOWER',
+            Piper::on('StrManipulator::strToLower')
+                ->to('strtoupper')
+                ->up()
+        );
+    }
 }
 
 class StrManipulator
@@ -170,7 +180,7 @@ public function __invoke(string $value)
         return $this->strToLower($value);
     }
 
-    public static function strToLower(string $value)
+    public static function strToLower(string $value = '')
     {
         return strtolower($value);
     }