Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build step of python-publish script #124

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Update build step of python-publish script #124

merged 1 commit into from
Nov 22, 2024

Conversation

tung-vu-td
Copy link
Contributor

Due to adoption of pyproject.toml instead of setup.py: #122, we need to update python-publish script

@imnutz imnutz self-requested a review November 22, 2024 04:41
imnutz
imnutz approved these changes Nov 22, 2024
View reviewed changes
Copy link

@imnutz imnutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tung-vu-td tung-vu-td requested a review from a team November 22, 2024 04:47
@tung-vu-td tung-vu-td merged commit 340ee37 into master Nov 22, 2024
22 checks passed
nmpennypacker
nmpennypacker reviewed Nov 22, 2024
View reviewed changes
Copy link

@nmpennypacker nmpennypacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for data exfiltrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmpennypacker nmpennypacker nmpennypacker left review comments

@imnutz imnutz imnutz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tung-vu-td @imnutz @nmpennypacker