refactor: change Node pointers to values #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topi314
force-pushed
the
refactor/node-value-receivers
branch
from
b4b762c
to
0e66c09
Compare
topi314
commented
Nov 10, 2024
| @@ -713,7 +713,7 @@ func (qc *QueryCursor) DidExceedMatchLimit() bool { | |||
| // captures. Because multiple patterns can match the same set of nodes, | |||
| // one match may contain captures that appear *before* some of the | |||
| // captures from a previous match. | |||
| func (qc *QueryCursor) Matches(query *Query, node *Node, text []byte) QueryMatches { | |||
There was a problem hiding this comment.
I am unsure if you also intended me to change this
| @@ -737,7 +737,7 @@ func (qc *QueryCursor) Matches(query *Query, node *Node, text []byte) QueryMatch | |||
| // | |||
| // This is useful if you don't care about which pattern matched, and just | |||
| // want a single, ordered sequence of captures. | |||
| func (qc *QueryCursor) Captures(query *Query, node *Node, text []byte) QueryCaptures { | |||
There was a problem hiding this comment.
I am unsure if you also intended me to change this
Comment on lines
-31
to
+32
| func (t *Tree) RootNodeWithOffset(offsetBytes int, offsetExtent Point) *Node { | ||
| return &Node{_inner: C.ts_tree_root_node_with_offset(t._inner, C.uint(offsetBytes), offsetExtent.toTSPoint())} | ||
| func (t *Tree) RootNodeWithOffset(offsetBytes int, offsetExtent Point) Node { | ||
| return Node{_inner: C.ts_tree_root_node_with_offset(t._inner, C.uint(offsetBytes), offsetExtent.toTSPoint())} |
There was a problem hiding this comment.
I am unsure if you also intended me to change this
Comment on lines
-25
to
+26
| func (t *Tree) RootNode() *Node { | ||
| return &Node{_inner: C.ts_tree_root_node(t._inner)} | ||
| func (t *Tree) RootNode() Node { | ||
| return Node{_inner: C.ts_tree_root_node(t._inner)} |
There was a problem hiding this comment.
I am unsure if you also intended me to change this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the method receivers of the
Nodetype to values instead of pointers for non mutating methods & pointer return type as discussed in #19 (comment)