Skip to content

Commit

Permalink
Test/helm chart ci (#28)
Browse files Browse the repository at this point in the history
* wip

* bump chart version

* run on PR

* lint-install run on PR
  • Loading branch information
johnnyaug committed Nov 23, 2020
1 parent 6ec2bb3 commit 07035f6
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 7 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on:
push:
branches: [master]
pull_request:
branches: []
jobs:
lint:
runs-on: ubuntu-latest
Expand All @@ -29,10 +28,10 @@ jobs:
- name: Create kind cluster
uses: helm/kind-action@v1.0.0
# Only build a kind cluster if there are chart changes to test.
if: ${{ steps.list-changed.outputs.changed == 'true' && github.event_name == 'push' }}
if: ${{ steps.list-changed.outputs.changed == 'true' }}
- name: Run chart-testing (install)
run: ct install
if: ${{ steps.list-changed.outputs.changed == 'true' && github.event_name == 'push' }}
if: ${{ steps.list-changed.outputs.changed == 'true' }}
release:
runs-on: ubuntu-latest
needs: lint
Expand Down
2 changes: 1 addition & 1 deletion charts/lakefs/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: lakefs
description: A Helm chart for Kubernetes
type: application
version: 0.4.3
version: 0.4.4
appVersion: 0.16.2

home: https://lakefs.io
Expand Down
Empty file.
3 changes: 3 additions & 0 deletions charts/lakefs/ci/secret-values.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
secrets:
databaseConnectionString: postgres://postgres:password@localhost:5432/postgres?sslmode=disable
authEncryptSecretKey: abcdefghi
6 changes: 4 additions & 2 deletions charts/lakefs/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ spec:
mountPath: "/lakefs/data"
{{- end }}
env:
{{- if .Values.lakefsConfig }}
{{- if .Values.secrets }}
- name: LAKEFS_DATABASE_CONNECTION_STRING
valueFrom:
secretKeyRef:
Expand All @@ -66,11 +66,13 @@ spec:
secretKeyRef:
name: {{ include "lakefs.fullname" . }}
key: auth_encrypt_secret_key
{{- else }}
{{- else if not .Values.lakefsConfig }}
- name: LAKEFS_DATABASE_CONNECTION_STRING
value: postgres://postgres:password@localhost:5432/postgres?sslmode=disable
- name: LAKEFS_AUTH_ENCRYPT_SECRET_KEY
value: asdjfhjaskdhuioaweyuiorasdsjbaskcbkj
{{- end }}
{{- if not .Values.lakefsConfig }}
- name: LAKEFS_BLOCKSTORE_LOCAL_PATH
value: /lakefs/data
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion charts/lakefs/templates/secret.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.lakefsConfig }}
{{- if .Values.secrets }}
apiVersion: v1
kind: Secret
metadata:
Expand Down

0 comments on commit 07035f6

Please sign in to comment.