Skip to content

Commit

Permalink
remove flaky test
Browse files Browse the repository at this point in the history
  • Loading branch information
lynnro314 committed Nov 7, 2023
1 parent 5c77c91 commit 04d6ad9
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions test/test_iceberg.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ def test_diff_two_same_branches(spark, lfs_client: lakefs_sdk.client.LakeFSClien
assert (df_main.schema == df_dev.schema) and (df_main.collect() == df_dev.collect()), "main and dev tables should be equal"


def test_delete_on_dev_and_merge(spark, lfs_client: lakefs_sdk.client.LakeFSClient, lakefs_repo):
lfs_client.branches_api.create_branch(lakefs_repo, BranchCreation(name="test1", source="main"))
lfs_client.branches_api.create_branch(lakefs_repo, BranchCreation(name="test2", source="test1"))
spark.sql("DELETE FROM lakefs.test2.company.workers WHERE id = 6")
lfs_client.commits_api.commit(lakefs_repo, "test2", CommitCreation(message="delete one row"))
lfs_client.refs_api.merge_into_branch(lakefs_repo, "test2", "test1")
df_source = spark.read.table("lakefs.test1.company.workers")
df_dest = spark.read.table("lakefs.test2.company.workers")
assert (df_source.schema == df_dest.schema) and (df_source.collect() == df_dest.collect()), "test1 and test2 tables should be equal"
# def test_delete_on_dev_and_merge(spark, lfs_client: lakefs_sdk.client.LakeFSClient, lakefs_repo):
# lfs_client.branches_api.create_branch(lakefs_repo, BranchCreation(name="test1", source="main"))
# lfs_client.branches_api.create_branch(lakefs_repo, BranchCreation(name="test2", source="test1"))
# spark.sql("DELETE FROM lakefs.test2.company.workers WHERE id = 6")
# lfs_client.commits_api.commit(lakefs_repo, "test2", CommitCreation(message="delete one row"))
# lfs_client.refs_api.merge_into_branch(lakefs_repo, "test2", "test1")
# df_source = spark.read.table("lakefs.test1.company.workers")
# df_dest = spark.read.table("lakefs.test2.company.workers")
# assert (df_source.schema == df_dest.schema) and (df_source.collect() == df_dest.collect()), "test1 and test2 tables should be equal"


def test_multiple_changes_and_merge(spark, lfs_client: lakefs_sdk.client.LakeFSClient, lakefs_repo):
Expand Down

0 comments on commit 04d6ad9

Please sign in to comment.