Fix bug when writing Parquet files #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaiad200
approved these changes
Jun 29, 2023
|
|
||
| import org.apache.hadoop.fs.Path; | ||
|
|
||
| public class LakeFSPath extends Path { |
There was a problem hiding this comment.
Why is this class needed? Please add documentation
johnnyaug
temporarily deployed
to
Treeverse signing
GitHub Actions
Inactive
johnnyaug
temporarily deployed
to
Treeverse signing
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23 (hopefully).
When handling Parquet, Iceberg gives special treatment when reading/writing to Hadoop. To do so, it checks if the FileInput/FileOutput is an instance of HadoopFileInput/HadoopFileOutput. For this to keep working with lakeFS, we must now use these classes instead of our dedicated ones.