Added test workflow with basic python test #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnro314
force-pushed
the
add-integration-tests
branch
2 times, most recently
from
1566344
to
13c76f3
Compare
lynnro314
force-pushed
the
add-integration-tests
branch
from
13c76f3
to
39d9026
Compare
lynnro314
force-pushed
the
add-integration-tests
branch
2 times, most recently
from
53a52e8
to
319829f
Compare
lynnro314
force-pushed
the
add-integration-tests
branch
3 times, most recently
from
f988ede
to
a1494e9
Compare
lynnro314
force-pushed
the
add-integration-tests
branch
6 times, most recently
from
527cf32
to
187034e
Compare
lynnro314
force-pushed
the
add-integration-tests
branch
from
187034e
to
e32e6b1
Compare
lynnro314
force-pushed
the
add-integration-tests
branch
from
d7101ea
to
71902b1
Compare
lynnro314
force-pushed
the
add-integration-tests
branch
from
2293bd1
to
d453ff1
Compare
lynnro314
force-pushed
the
add-integration-tests
branch
from
d453ff1
to
d90d80d
Compare
johnnyaug
approved these changes
Jul 13, 2023
.github/workflows/tests.yml
Outdated
|
|
||
| jobs: | ||
| iceberg-isolation-test: | ||
| name: Test lakeFS isolation with iceberg |
There was a problem hiding this comment.
Why specifically "isolation"? This is testing lakeFS with Iceberg
.github/workflows/tests.yml
Outdated
| runs-on: ubuntu-20.04 | ||
| services: | ||
| lakefs: | ||
| image: "treeverse/lakefs:latest" |
There was a problem hiding this comment.
May be better to lock the version number here. There is a trade-off, but I think consistency wins over freshness.
.github/workflows/tests.yml
Outdated
| run: | | ||
| python ./test/run-test.py \ | ||
| --storage_namespace s3://iceberg-lakefs-testing/${{ github.run_number }}-s3-gateway/${{ steps.unique.outputs.value }} \ | ||
| --repository gateway-test \ |
| lfs_client.branches.create_branch(repo_name, BranchCreation(name="dev", source="main")) | ||
| df_main = spark.read.table("lakefs.main.nyc.permits") | ||
| df_dev = spark.read.table("lakefs.dev.nyc.permits") | ||
| assert (df_main.schema == df_dev.schema) and (df_main.collect() == df_dev.collect()), "main and dev tables should be equal" |
There was a problem hiding this comment.
In a future PR, can we use some Python testing framework here? To manage the test cases and report the failures.
There was a problem hiding this comment.
Of course, this is how it will be.
lynnro314
force-pushed
the
add-integration-tests
branch
from
86406ce
to
84be76f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.