-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added pytest #36
added pytest #36
Conversation
523b8de
to
5d68471
Compare
76a4187
to
3d96e57
Compare
3d96e57
to
dc9b60f
Compare
dc9b60f
to
78580e0
Compare
b3d9bad
to
ab4ac82
Compare
ab4ac82
to
d296829
Compare
7f926ba
to
ecc4e78
Compare
ecc4e78
to
e8c42d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Some formatting comments.
test/conftest.py
Outdated
key=AccessKeyCredentials(access_key_id=LAKEFS_ACCESS_KEY, secret_access_key=LAKEFS_SECRET_KEY))) | ||
lfs_client.repositories_api.create_repository( | ||
RepositoryCreation(name=repo_name, storage_namespace=storage_namespace)) | ||
return lfs_client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add line break at the end
test/conftest.py
Outdated
repo_name = pytestconfig.getoption('--repository') | ||
storage_namespace = pytestconfig.getoption('--storage_namespace') | ||
lfs_client.internal_api.setup_comm_prefs(CommPrefsInput(feature_updates=False, security_updates=False, email=MOCK_EMAIL)) | ||
lfs_client.internal_api.setup(Setup(username="lynn", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lfs_client.internal_api.setup(Setup(username="lynn", | |
lfs_client.internal_api.setup(Setup(username="admin", |
test/test_iceberg.py
Outdated
lfs_client.refs_api.merge_into_branch(lakefs_repo, "test4", "test3") | ||
df_source = spark.read.table("lakefs.test3.company.workers") | ||
df_dest = spark.read.table("lakefs.test4.company.workers") | ||
assert (df_source.schema == df_dest.schema) and (set(df_source.collect()) == set(df_dest.collect())), "test3 and test4 tables should be equal" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linebreak
from pyspark.conf import SparkConf | ||
|
||
import pytest | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove spaces
No description provided.