Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pytest #36

Merged
merged 18 commits into from
Nov 7, 2023
Merged

added pytest #36

merged 18 commits into from
Nov 7, 2023

Conversation

lynnro314
Copy link
Contributor

No description provided.

@lynnro314 lynnro314 force-pushed the add-test-cases-integration-tests branch from 523b8de to 5d68471 Compare July 30, 2023 22:04
@lynnro314 lynnro314 force-pushed the add-test-cases-integration-tests branch from 76a4187 to 3d96e57 Compare October 29, 2023 09:06
@lynnro314 lynnro314 force-pushed the add-test-cases-integration-tests branch from 3d96e57 to dc9b60f Compare November 1, 2023 10:31
@lynnro314 lynnro314 force-pushed the add-test-cases-integration-tests branch from dc9b60f to 78580e0 Compare November 1, 2023 11:07
@lynnro314 lynnro314 force-pushed the add-test-cases-integration-tests branch 3 times, most recently from b3d9bad to ab4ac82 Compare November 1, 2023 14:36
@lynnro314 lynnro314 force-pushed the add-test-cases-integration-tests branch from ab4ac82 to d296829 Compare November 1, 2023 15:38
@lynnro314 lynnro314 force-pushed the add-test-cases-integration-tests branch from 7f926ba to ecc4e78 Compare November 2, 2023 16:08
@lynnro314 lynnro314 force-pushed the add-test-cases-integration-tests branch from ecc4e78 to e8c42d2 Compare November 2, 2023 16:11
@lynnro314 lynnro314 marked this pull request as ready for review November 7, 2023 09:14
Copy link
Contributor

@johnnyaug johnnyaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some formatting comments.

test/conftest.py Outdated
key=AccessKeyCredentials(access_key_id=LAKEFS_ACCESS_KEY, secret_access_key=LAKEFS_SECRET_KEY)))
lfs_client.repositories_api.create_repository(
RepositoryCreation(name=repo_name, storage_namespace=storage_namespace))
return lfs_client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line break at the end

test/conftest.py Outdated
repo_name = pytestconfig.getoption('--repository')
storage_namespace = pytestconfig.getoption('--storage_namespace')
lfs_client.internal_api.setup_comm_prefs(CommPrefsInput(feature_updates=False, security_updates=False, email=MOCK_EMAIL))
lfs_client.internal_api.setup(Setup(username="lynn",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lfs_client.internal_api.setup(Setup(username="lynn",
lfs_client.internal_api.setup(Setup(username="admin",

lfs_client.refs_api.merge_into_branch(lakefs_repo, "test4", "test3")
df_source = spark.read.table("lakefs.test3.company.workers")
df_dest = spark.read.table("lakefs.test4.company.workers")
assert (df_source.schema == df_dest.schema) and (set(df_source.collect()) == set(df_dest.collect())), "test3 and test4 tables should be equal"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linebreak

from pyspark.conf import SparkConf

import pytest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove spaces

@lynnro314 lynnro314 merged commit 7f59306 into main Nov 7, 2023
1 check passed
@lynnro314 lynnro314 deleted the add-test-cases-integration-tests branch November 7, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants