SBT publish... and add tests to main itself #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on GitHub's default.
Spark doesn't like a newer JRE.
CI is currently so cheap, it's better to run it always.
It fails reporting, and actions suggested in https://github.com/marketplace/actions/sbt-dependency-submission#unexpected-status-403 don't work and are also not particularly safe.
Add a unit test
Merged
|
I will pull with any reviewer's approval, unless otherwise requested! |
Jonathan-Rosenberg
approved these changes
Aug 21, 2023
| credentials += Credentials( | ||
| "GnuPG Key ID", | ||
| "gpg", | ||
| "F638279A7281EE8EAE58C4B98D3CFE7E7D0262DA", // key identifier |
There was a problem hiding this comment.
is this supposed to be public?
There was a problem hiding this comment.
Yeah, it's confusing and scary!
It's the public key for lakeFS signing. We do the same in lakeFSFS.
arielshaqed
commented
Aug 21, 2023
| credentials += Credentials( | ||
| "GnuPG Key ID", | ||
| "gpg", | ||
| "F638279A7281EE8EAE58C4B98D3CFE7E7D0262DA", // key identifier |
There was a problem hiding this comment.
Yeah, it's confusing and scary!
It's the public key for lakeFS signing. We do the same in lakeFSFS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests were reviewed in #1 but incorrectly merged.
The real diff here is in .sbt files.