Use region and stage from the provider. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in Serverless 1.25.0 there are no getRegion and getStage functions on the provider object. These should be used as stage and region as they are values used by other parts of the system as well. Here is the diff when the change was added. serverless/serverless@bf8d57f#diff-a3c9979defeb57f83384efb5246290db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
If you did not provide the stage variable on the command line the the deploy would fail.
Missing required key 'Value' in params.Tags[0]See #7 for another example.
The reason
The plugin options were built using only the command line options and the custom options. The provider was ignored.
What I did
Supporting change from serverless 1.25.0
Starting in Serverless 1.25.0 there are now getRegion and getStage functions on the provider object.
These should be used as stage and region as they are values used by other parts of the system as well.
Here is the diff when the change was added. serverless/serverless@bf8d57f#diff-a3c9979defeb57f83384efb5246290db