Fix python2 compatibility issue with X509 DER parsing

.checkignore

@@ -0,0 +1,3 @@
+scripts/**
+tests/**
+unit_tests/**

.codeclimate.yml

@@ -0,0 +1,39 @@
+engines:
+  radon:
+    enabled: true
+    config:
+      threshold: "C"
+  pep8:
+    enabled: true
+  duplication:
+    enabled: true
+    exclude_fingerprints:
+    # duplication in tlslite/utils/codec.py Writer.addTwo() .addFour()
+    - 2e783666ce368f4223c1e7f5b162e2d9
+    - 2c398389f33ea2572edefc5370ed49c0
+    config:
+      languages:
+        python:
+          python_version: 3
+          mass_threshold: 35
+  fixme:
+    enabled: true
+    config:
+      strings:
+        - TODO
+        - FIXME
+        - HACK
+        - BUG
+    checks:
+      bug:
+        enabled: true
+  markdownlint:
+    enabled: true
+ratings:
+  paths:
+  - "tlslite/**"
+  - "**.py"
+exclude_paths:
+ - "tests/**/*"
+ - "scripts/**/*"
+ - "unit_tests/**/*"

.gitignore

@@ -3,8 +3,9 @@
 .pydevproject
 .settings
 .coverage
+.hypothesis
 coverage.xml
 pylint_report.txt
 build/
-docs/
+docs/_build/
 htmlcov/

.landscape.yaml

@@ -0,0 +1,16 @@
+doc-warnings: true
+
+test-warnings: false
+
+strictness: medium
+
+max-line-length: 80
+
+ignore-paths:
+    - tests
+    - unit_tests
+    - scripts
+
+pep257:
+    disable:
+        - D203

.pep257

@@ -0,0 +1,3 @@
+[pep257]
+
+add-ignore = D203

.travis.yml

@@ -1,5 +1,13 @@
 language: python
 
+# whitelist branches on which tests will be run
+branches:
+  only:
+    - master
+    - tlslite-ng-0.5
+    - tlslite-ng-0.6
+    - tlslite-ng-0.7
+
 addons:
   apt_packages:
     # needed for M2Crypto
@@ -13,6 +21,9 @@ python:
   - 3.2
   - 3.3
   - 3.4
+  - 3.5
+  - 3.6
+  - 3.7-dev
 
 env:
   - TACKPY=true
@@ -28,19 +39,40 @@ matrix:
       env: TACKPY=true
     - python: 2.7
       env: M2CRYPTO=true
-# no M2crypto on Python 3
+    - python: 3.4
+      env: M2CRYPTO=true
+    - python: 3.5
+      env: M2CRYPTO=true
+    - python: 3.6
+      env: M2CRYPTO=true
     - python: 2.7
       env: PYCRYPTO=true
     - python: 3.4
       env: PYCRYPTO=true
+    - python: 3.5
+      env: PYCRYPTO=true
+    - python: 3.6
+      env: PYCRYPTO=true
+    - python: 3.7-dev
+      env: PYCRYPTO=true
     - python: 2.7
       env: GMPY=true
     - python: 3.4
       env: GMPY=true
+    - python: 3.5
+      env: GMPY=true
+    - python: 3.6
+      env: GMPY=true
     - python: 2.7
       env: M2CRYPTO=true PYCRYPTO=true GMPY=true
     - python: 3.4
-      env: PYCRYPTO=true GMPY=true
+      env: M2CRYPTO=true PYCRYPTO=true GMPY=true
+    - python: 3.5
+      env: M2CRYPTO=true PYCRYPTO=true GMPY=true
+    - python: 3.6
+      env: M2CRYPTO=true PYCRYPTO=true GMPY=true
+    - python: 3.7-dev
+      env: M2CRYPTO=true PYCRYPTO=true GMPY=true
 
 before_install:
   - |
@@ -57,15 +89,20 @@ before_install:
          PR_FIRST=$(curl --silent --show-error --location $URL | head -1 | grep -o -E '\b[0-9a-f]{40}\b' | tr -d '\n')
          TRAVIS_COMMIT_RANGE=$PR_FIRST^..$TRAVIS_COMMIT
        fi
+  # sanity check current commit
+  - git rev-parse HEAD
   - echo "TRAVIS_COMMIT_RANGE=$TRAVIS_COMMIT_RANGE"
   - git fetch origin master:refs/remotes/origin/master
 
 install:
-  - if [[ $TRAVIS_PYTHON_VERSION == '2.6' ]]; then travis_retry pip install unittest2; fi
+  - if [[ $TRAVIS_PYTHON_VERSION == '2.6' ]]; then travis_retry pip install unittest2 'isort<4.3'; fi
+  - if [[ $TRAVIS_PYTHON_VERSION == '2.7' ]]; then travis_retry pip install unittest2; fi
   - if [[ $TACKPY == 'true' ]]; then travis_retry pip install tackpy; fi
-  - if [[ $M2CRYPTO == 'true' ]]; then travis_retry pip install M2Crypto; fi
+  - if [[ $M2CRYPTO == 'true' ]]; then travis_retry pip install --pre m2crypto; fi
   - if [[ $PYCRYPTO == 'true' ]]; then travis_retry pip install pycrypto; fi
   - if [[ $GMPY == 'true' ]]; then travis_retry pip install gmpy; fi
+  - if [[ $TRAVIS_PYTHON_VERSION == '3.2' ]]; then travis_retry pip install 'coverage<4' 'hypothesis<1.10'; elif [[ $TRAVIS_PYTHON_VERSION == '3.3' ]]; then travis_retry pip install 'coverage' 'hypothesis<3.44' ; elif [[ $TRAVIS_PYTHON_VERSION == '2.6' ]]; then travis_retry pip install coverage 'hypothesis<3'; else travis_retry pip install coverage hypothesis; fi
+  - travis_retry pip install -r requirements.txt
   - travis_retry pip install -r build-requirements.txt
 
 script:
@@ -84,20 +121,23 @@ script:
         pylint --msg-template="{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}" tlslite > pylint_report.txt || :
         diff-quality --violations=pylint --fail-under=90 pylint_report.txt
       fi
-  - echo "Will test commits between $TRAVIS_COMMIT_RANGE:"
-  - git log --oneline --reverse $TRAVIS_COMMIT_RANGE
-  - | 
-      for i in $(git log --pretty=format:%H --reverse $TRAVIS_COMMIT_RANGE); do
-        git checkout $i
-        make clean
-        if [[ $TRAVIS_PYTHON_VERSION == '2.6' ]]; then
-          unit2 discover || exit 1
-        else
-          python -m unittest discover || exit 1
-        fi
-        make test-local || exit 1
-        cd $TRAVIS_BUILD_DIR
-      done
+  - |
+      if [[ $TRAVIS_PULL_REQUEST != "false" ]]; then
+        echo "Will test commits between $TRAVIS_COMMIT_RANGE:"
+        git log --oneline --reverse $TRAVIS_COMMIT_RANGE
+
+        for i in $(git log --pretty=format:%H --reverse $TRAVIS_COMMIT_RANGE); do
+          git checkout $i
+          make clean
+          if [[ $TRAVIS_PYTHON_VERSION == '2.6' ]]; then
+            unit2 discover || exit 1
+          else
+            python -m unittest discover || exit 1
+          fi
+          make test-local || exit 1
+          cd $TRAVIS_BUILD_DIR
+        done
+      fi
 
 sudo: false
 

CONTRIBUTING.md

@@ -0,0 +1,134 @@
+# How to contribute
+
+## How to prepare
+
+* You need a [GitHub account](https://github.com/signup/free)
+* Submit an [issue ticket](https://github.com/tomato42/tlslite-ng/issues) for
+  your issue if there is none yet.
+  * Describe the issue and include steps to reproduce if it's a bug, mention
+    the earliest version that you know is affected and the version you're using.
+  * Describe the enhancement and your general ideas on how to implement it
+    if you want to add new feature or extend existing one. This is not
+    necessary if the change is small.
+* If you are able and want to fix the issue, fork the repository on GitHub
+
+## Technical requirements
+
+To be able to work on the code you will need few pieces of software installed.
+The most important is `python` interpreter. Some development dependencies have
+additional restrictions on the versions used, so I recommend Python 2.7 or
+Python 3.4 as the lowest versions (see .travis.yml if you want details).
+Git client, make, text editor and ability to
+install local python packages (ability to run pip).
+
+The list goes as follows:
+
+* python (2.7 or 3.4)
+* git
+* GNU make
+* pip
+* sphinx
+
+The python module dependencies are as follows:
+
+* unittest (unittest2 on Python 2; should be part of Python 3 install)
+* mock (should be part of Python 3 distribution of unittest)
+* ecdsa
+* pylint
+* diff_cover
+* coverage
+* hypothesis
+* enum34 (for Python2, in case of new hypothesis package)
+
+On Fedora they can be installed using:
+
+```
+dnf install python-ecdsa python3-ecdsa pylint python3-pylint python-diff-cover \
+    python3-diff-cover python-coverage python3-coverage python2-hypothesis \
+    python3-hypothesis python3-libs python-unittest2 python-mock python3-sphinx
+```
+
+On RHEL 7 you will need to enable [EPEL](https://fedoraproject.org/wiki/EPEL),
+and install [pip](https://pip.pypa.io/en/stable/installing/) for Python3,
+after which you can install the dependencies using:
+
+```
+yum install python-ecdsa python34-ecdsa pylint \
+    python-coverage python34-coverage python2-hypothesis \
+    python34-libs python-unittest2 python-mock python-pip python-sphinx
+pip2 install diff-cover
+pip3 install hypothesis diff-cover pylint
+```
+
+Optional module dependencies:
+
+* tackpy
+* m2crypto
+* pycrypto
+* gmpy
+
+On Fedora they can be installed using:
+
+```
+pip install tackpy
+dnf install m2crypto python-crypto python3-crypto python-gmpy2 python3-gmpy2
+```
+
+## Make changes
+
+* In your forked repository, create a topic branch for your upcoming patch
+  (e.g. 'implement-aria' or 'bugfix-osx-crash')
+  * usually this is based on the master branch
+  * to create branch based on master: `git branch <example-name>` then
+    checkout the branch `git checkout <example-name>`. For your own convinience
+    avoid working directly on the `master` branch.
+* Make sure you stick to the coding style that is used in surrounding code
+  * you can use `pylint --msg-template="{path}:{line}: [{msg_id}({symbol}),
+    {obj}] {msg}" tlslite > pylint_report.txt; diff-quality --violations=pylint
+    pylint_report.txt` to see if your changes do not violate the general
+    guidelines (alternatively you can just run `make test-dev` as described
+    below).
+* Make commits of logical units and describe them properly in commits
+  * When creating a comment, keep the first line short and separate it from
+    the rest by whiteline
+  * See also [OpenStack guide](https://wiki.openstack.org/wiki/GitCommitMessages)
+    for general good ideas about git commit messages
+* Check for unnecessary whitespace with `git diff --check` before committing
+
+* Generally newly submitted code should have test coverage so that it can
+  be clearly shown that it works correctly.
+  * pull requests with code refactoring of code that does not have test
+    coverage should have test coverage of the code added first
+* Assure nothing is broken by running all tests using `make test-dev`
+  * Pull requests that fail the last check of the `test-dev` target,
+    the test coverage check, may still be accepted, but making pull request
+    that passes it is the best way to make the review quick.
+
+## Submit changes
+
+* Push your changes to a topic branch in your fork of the repository.
+* Open a pull request to the original repository and choose the right original
+  branch you want to patch (that usually will be tomato42/master).
+* If you posted issues previously, make sure you reference them in the opening
+  commit of the pull request (e.g. 'fixes #12'). But _please do not close the
+  issue yourself_. GitHub will do that automatically once the issue is merged.
+* Wait for checks to pass. Travis-ci check is mandatory, pull requests which
+  fail it will not be merged. Landscape and coveralls failures are not blocking
+  but may require explanation. Going to codeclimate and quantified code
+  (see README.md for links) and checking the branch and pull request is also
+  a good idea.
+  * if you are not sure if the pull will pass the checks it is OK to submit
+    a test pull request, but please mark it as such ('[WIP]' in title is
+    enough)
+* Once you recieve feedback from reviewers or from the automated systems,
+  modify your local patches (that usually means that you need to prepare
+  "fixup" patches or interactively
+  [rebase](https://help.github.com/articles/about-git-rebase/)) and push
+  updated branch to github (that usually will require to perform a
+  [force push](http://movingfast.io/articles/git-force-pushing/))
+* Wait again for review or automated checks.
+
+## Additional Resources
+
+* [General GitHub documentation](http://help.github.com/)
+* [GitHub pull request documentation](http://help.github.com/send-pull-requests/)