Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GstCameraPlugin: apply code style and remove env variable options #2

Conversation

srmainwaring
Copy link

Review feedback for ArduPilot#97.

@srmainwaring srmainwaring force-pushed the prs/pr-gstreamer-plugin branch 2 times, most recently from 65eccac to 62f84a5 Compare June 20, 2024 21:43
@srmainwaring srmainwaring changed the title GstCameraPlugin: apply code style and update code documentation GstCameraPlugin: apply code style and remove env variable options Jun 20, 2024
@srmainwaring srmainwaring force-pushed the prs/pr-gstreamer-plugin branch from 62f84a5 to 3f23868 Compare June 20, 2024 21:46
@srmainwaring srmainwaring force-pushed the prs/pr-gstreamer-plugin branch 2 times, most recently from 360ccde to f8823e1 Compare June 24, 2024 09:17
- Update class and parameter documentation.
- Apply Gazebo code style (mainly removing cuddled braces).
- Use snake case for SDF elements.
- Remove the environment variable defaults.
- Require mandatory fields are set in SDF.
- Use sensor topic name as default for image topic.
- Use sensor topic name as prefix for enable streaming topic.
- Update class doc string.
- Update gz message strings.
- Ensure streaming stops / starts when requested.

Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
@srmainwaring srmainwaring force-pushed the prs/pr-gstreamer-plugin branch from f8823e1 to 083ae45 Compare June 24, 2024 09:50
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
@srmainwaring
Copy link
Author

Closing as pushed changes directly to ArduPilot#97.

@srmainwaring srmainwaring deleted the prs/pr-gstreamer-plugin branch June 24, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant