Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better integration of Slip39_Single backup type #3868

Closed
3 of 4 tasks
matejcik opened this issue May 28, 2024 · 0 comments · Fixed by #3899 or #4425
Closed
3 of 4 tasks

Better integration of Slip39_Single backup type #3868

matejcik opened this issue May 28, 2024 · 0 comments · Fixed by #3899 or #4425
Assignees
@ibz
Labels
code Code improvements low hanging fruit Simple, quick task.

Comments

@matejcik
Copy link
Contributor

matejcik commented May 28, 2024 •
edited by ibz
Loading

  • add tests for Slip39_Single alongside existing tests for Slip39_Basic + 1-of-1 specified in BackupDevice
  • handle situation when backup is repeated but stored type is Slip39_Single
    • either we should treat it as "Basic" and allow the user to hand-configure the shares
    • or reject the message
  • allow the user to specify a different backup style with BackupDevice, i.e., Advanced or Single when the type is Basic, and so on (let's do this later)
  • convert stored type to Slip39_Basic (or Advanced, as appropriate) when doing a basic backup out of a single one

depends on #3825 and #3640
@matejcik matejcik added the code Code improvements label May 28, 2024
@ibz ibz linked a pull request Jun 11, 2024 that will close this issue
chore(core): add ability to set up a device with SLIP39 "single" #3899
Merged
@Hannsek Hannsek added the low hanging fruit Simple, quick task. label Oct 30, 2024
@Hannsek Hannsek moved this to 🎯 To do in Firmware Oct 30, 2024
@ibz ibz linked a pull request Dec 6, 2024 that will close this issue
Add test for Slip39_Single #4425
Merged
@ibz ibz closed this as completed in #4425 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibz ibz

Labels
code Code improvements low hanging fruit Simple, quick task.
Projects
Firmware
Status: 🎯 To do
Milestone
No milestone
3 participants
@ibz @matejcik @Hannsek