Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for Slip39_Single #4425

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Add test for Slip39_Single #4425

merged 2 commits into from
Dec 20, 2024

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Dec 6, 2024 •
edited
Loading

No description provided.

@ibz ibz self-assigned this Dec 6, 2024
@ibz ibz linked an issue Dec 6, 2024 that may be closed by this pull request
Better integration of Slip39_Single backup type #3868
Closed
4 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@ibz ibz marked this pull request as ready for review December 6, 2024 10:00
@ibz ibz requested a review from matejcik as a code owner December 6, 2024 10:00
obrusvit
obrusvit approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be cleaner to use InputFlowSlip39CustomBackup instead of InputFlowBip39 but it's fine.

EDIT: I'm not sure that our update_fixtures.py tool allows adding new tests from CI 🤔 Probably yes, but make sure that fixtures.json are updated for all languages

@obrusvit obrusvit added core Trezor Core firmware. Runs on Trezor Model T and T2B1. tests Automated integration tests translations Put this label on a PR to run tests in all languages and removed translations Put this label on a PR to run tests in all languages labels Dec 19, 2024
@ibz ibz force-pushed the ibz/slip-single-test branch from 9a203c6 to 1ba891e Compare December 19, 2024 11:34
@ibz ibz merged commit f10dc86 into main Dec 20, 2024
138 of 139 checks passed
@ibz ibz deleted the ibz/slip-single-test branch December 20, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrusvit obrusvit obrusvit approved these changes

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

Assignees

@ibz ibz

Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. tests Automated integration tests translations Put this label on a PR to run tests in all languages
Projects
Firmware
Status: 🤝 Needs QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better integration of Slip39_Single backup type
2 participants
@ibz @obrusvit