Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display driver refactoring #3979

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Display driver refactoring #3979

wants to merge 8 commits into from

Conversation

cepetr
Copy link
Contributor

@cepetr cepetr commented Jun 25, 2024

This PR focuses on refactoring the display driver and preparing it for entering and exiting low power mode.

[!!not ready for review yet]

  1. Introduces new initialization and deinitialization routines: display_init(mode) and display_deinit(mode). These replace the previously used display_init(), display_reinit(), and display_finish_actions.
  2. Splits ensure_compatible_settings() into a new function specific to the T model and incorporates the rest inside new display_init/display_deinit logic.
  3. Enhances the robustness of the display driver API by introducing an initialized state to all display drivers.

@cepetr cepetr added T2B1 Trezor Safe 3 T2T1 Trezor Model T T3T1 T3B1 labels Jun 25, 2024
@cepetr cepetr self-assigned this Jun 25, 2024
@cepetr cepetr force-pushed the cepetr/low-power-display branch 2 times, most recently from 141b1cc to f045b2b Compare August 9, 2024 12:27
@cepetr cepetr force-pushed the cepetr/low-power-display branch 2 times, most recently from c731294 to 2c0be24 Compare August 30, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2B1 Trezor Safe 3 T2T1 Trezor Model T T3B1 T3T1
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

1 participant