trezor-core-tools python package #4078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejcik
force-pushed
the
matejcik/trezor-core-tools
branch
from
246cab3
to
39aec66
Compare
|
tagging @TychoVrahe for |
TychoVrahe
reviewed
Aug 6, 2024
obrusvit
reviewed
Aug 6, 2024
| STORAGE_1_SECTOR_END = $(shell python ./tools/layout_parser.py ${LAYOUT_FILE} STORAGE_1_SECTOR_END) | ||
| STORAGE_2_SECTOR_START = $(shell python ./tools/layout_parser.py ${LAYOUT_FILE} STORAGE_2_SECTOR_START) | ||
| STORAGE_2_SECTOR_END = $(shell python ./tools/layout_parser.py ${LAYOUT_FILE} STORAGE_2_SECTOR_END) | ||
| FLASH_START = $(shell layout_parser ${TREZOR_MODEL} FLASH_START) |
There was a problem hiding this comment.
FLASH_START seems to be unused.
There was a problem hiding this comment.
i'd keep it around in case something like make flash would use it? wdyt @TychoVrahe
| FIRMWARE_P1_MAXSIZE = $(shell layout_parser ${TREZOR_MODEL} FIRMWARE_P1_IMAGE_MAXSIZE) | ||
| FIRMWARE_P2_MAXSIZE = $(shell layout_parser ${TREZOR_MODEL} FIRMWARE_P2_IMAGE_MAXSIZE) | ||
| BOARDLOADER_SECTOR_START = $(shell layout_parser ${TREZOR_MODEL} BOARDLOADER_SECTOR_START) | ||
| BOARDLOADER_SECTOR_END = $(shell layout_parser ${TREZOR_MODEL} BOARDLOADER_SECTOR_END) |
There was a problem hiding this comment.
BOARDLOADER_SECTOR_START and BOARDLOADER_SECTOR_END seem to be unused.
obrusvit
approved these changes
Aug 28, 2024
…ools so that we can have them available globally inside the poetry shell
matejcik
force-pushed
the
matejcik/trezor-core-tools
branch
from
e2e4e99
to
626afd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this, essentially, replaces
./core/tools/headertool.pywith justheadertoolalso improves
combine_firmwareso that it (a) accepts model name as an argument, instead of path to the header file, (b) accepts lowercase section names, (c) is friendlier when you mess up a section name