feat(core): improve ETH send flow.

[ibz]

Refs #3858

[github-actions]

core UI changes	device test	click test	persistence test
T2T1 Model T	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
T2B1 Safe 3	test(screens) main(screens)	test(screens) main(screens)	2724
T3T1	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
All	main(screens)

[github-actions]

legacy UI changes	device test(screens) main(screens)

[ibz]

Here are screenshots from the screens of the flow...

Note: Account info screen missing for now, since we don't have the account # and wallet info...

[obrusvit]

Some points to discuss regarding the flow.

UI part in rust seems good 👍

[obrusvit]

This PR also adds Success screen with "Transaction signed" and "Continue in the app" for all models.

But I don't think it's desirable UX-wise e.g. when you Stake.
I think the success screens are designed for TS5 only and the idea for the future is to have them timeout after a few seconds while TrezorSuite already gets the result (Success). This is not yet possible, tracked here #3666

So I would remove the Success screen for now.

[ibz]

So I would remove the Success screen for now.

OK, I'll remove the success screen from all models then, as discussed with you (re #3666).

What about the progress screen - does it even make sense given it is not a "real" progress and the signing is pretty fast? @Hannsek

[Hannsek]

Progress screen "signing transaction" is quick for small transaction, for bigger transaction it is not that quick. Let's keep it.

[ibz]

So I would remove the Success screen for now.

#4095 (comment)

[obrusvit]

Sending ETH works nicely 👍

Apart from the individual comments, I'd like to discuss a few more points:

• the new_confirm_summary is very very long, perhaps we can break it down into smaller pieces or even flows
• ETH confirm stake/unstake/claim flows are broken now - they don't show the info according to Figma. The flow in python function was not changed but we changed the confirm_summary.rs which now disrupts it. We should check whether it can be mapped to the new confirm_summary but I'm afraid we'd have to write a new flow_. I can help.
• I didn't check other operations on ETH, e.g. with data or unknown contract etc.

[obrusvit]

There's a limitation in the ButtonRequest behavior of the confirm_output as it does not send the BR everytime if the user goes back and forth. We ignore it for now because Suite does not handle them repeatedly anyway.

We realized that sending BR from rust on every Event::Attach is not equivalent to sending BR in a while loop with from uPy. A layout started from uPy has two pages, it sends only one BR
A usage of .repeated_button_request from rust sends it twice for every page.

[Hannsek]

@ibz next time please ping @lapohoda to check it. :)

[bosomt]

QA OK

• Device: Trezor T3T1 2.8.2 regular (revision d7e1f0f)