-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): improve ETH send flow. #4095
Conversation
|
|
78bec4a
to
857c659
Compare
67b5872
to
86dd94c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some points to discuss regarding the flow.
UI part in rust seems good 👍
This PR also adds Success screen with "Transaction signed" and "Continue in the app" for all models. But I don't think it's desirable UX-wise e.g. when you Stake. So I would remove the Success screen for now. |
Progress screen "signing transaction" is quick for small transaction, for bigger transaction it is not that quick. Let's keep it. |
1eecdc0
to
acb1cde
Compare
|
c5ac68b
to
e155de8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sending ETH works nicely 👍
Apart from the individual comments, I'd like to discuss a few more points:
- the
new_confirm_summary
is very very long, perhaps we can break it down into smaller pieces or even flows - ETH confirm stake/unstake/claim flows are broken now - they don't show the info according to Figma. The flow in python function was not changed but we changed the
confirm_summary.rs
which now disrupts it. We should check whether it can be mapped to the newconfirm_summary
but I'm afraid we'd have to write a newflow_
. I can help. - I didn't check other operations on ETH, e.g. with data or
unknown contract
etc.
There's a limitation in the ButtonRequest behavior of the We realized that sending |
5f06900
to
f25f7e1
Compare
da544fa
to
c930c8a
Compare
QA OK
|
Refs #3858