Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bieleluk/wipe code flow #4451

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Bieleluk/wipe code flow #4451

wants to merge 2 commits into from

Conversation

bieleluk
Copy link
Contributor

@bieleluk bieleluk commented Dec 16, 2024

This PR:

  • aligns wipe code flow for Mercury model with Figma

Changes include

  • adding extra parameters to set_new_pin to differentiate between the PIN and wipe code
  • adding new flow set_new_wipe_code because the existing one diverges too much
  • adapt warnings in PIN and wipe code flows according to Figma: wipe code and PIN

This PR should be merged only after 4447

@bieleluk bieleluk added this to the T3T1 milestone Dec 16, 2024
@bieleluk bieleluk self-assigned this Dec 16, 2024
@bieleluk bieleluk linked an issue Dec 16, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 16, 2024

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@Hannsek
Copy link
Contributor

Hannsek commented Dec 17, 2024

The screens still look off, e.g amount in header.

@bieleluk
Copy link
Contributor Author

@Hannsek

  • The amount of PIN attempts is there on purpose, because the user can actually run out of the PIN attempts when running this flow multiple times.
  • The formatting of warnings in general is currently a bit off but will be unified in the future.

@Hannsek
Copy link
Contributor

Hannsek commented Dec 18, 2024

cool, please let me know once it will be ready. I'll take a look. 🙏🏻

@bieleluk bieleluk force-pushed the bieleluk/wipe-code-flow branch from 8f8b813 to 5e9dc98 Compare December 19, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

Wipe code flow
2 participants