feat: detect payload signing type for WalletConnect #2309
Merged
+62
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dianasavvatina
force-pushed
the
wc_signpayload
branch
from
6eb4ad8 to
1e99b03
Compare
dianasavvatina
force-pushed
the
wc_signpayload
branch
from
1e99b03 to
5c56abf
Compare
OKendigelyan
approved these changes
Jan 13, 2025
| @@ -83,16 +87,26 @@ describe("decodeBeaconPayload", () => { | |||
|
|
|||
| it("handles an empty payload", () => { | |||
| const emptyPayload = ""; | |||
There was a problem hiding this comment.
We can move this const somewhere higher to use it everywhere
| const signPayloadProps: SignPayloadProps = { | ||
| appName: session.peer.metadata.name, | ||
| appIcon: session.peer.metadata.icons[0], | ||
| payload: request.params.payload, | ||
| isScam: event.verifyContext.verified.isScam, | ||
| validationStatus: event.verifyContext.verified.validation, | ||
| signer: signer, | ||
| signingType: SigningType.RAW, | ||
| signingType: signingType, |
There was a problem hiding this comment.
signingType: signingType => signingType
dianasavvatina
force-pushed
the
wc_signpayload
branch
from
5c56abf to
e17bef5
Compare
dianasavvatina
force-pushed
the
wc_signpayload
branch
from
e17bef5 to
d1d1a3c
Compare
dianasavvatina
force-pushed
the
wc_signpayload
branch
from
d1d1a3c to
8a073ff
Compare
dianasavvatina
force-pushed
the
wc_signpayload
branch
from
8a073ff to
be751dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Improved payload representation if the
unpackDatafailsTypes of changes
Steps to reproduce
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Before:
Taquito:
Now:
Test dApp with Tezos Provider
Taquito test dApp
fxhash
objkt
Checklist