-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WalletConnect - advanced error handling #2315
Open
dianasavvatina
wants to merge
2
commits into
main
Choose a base branch
from
wc_errh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+291
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dianasavvatina
force-pushed
the
wc_errh
branch
from
January 13, 2025 10:58
a654fb7
to
cb2e8d8
Compare
dianasavvatina
force-pushed
the
wc_errh
branch
from
January 13, 2025 11:45
cb2e8d8
to
d2c0451
Compare
dianasavvatina
force-pushed
the
wc_errh
branch
from
January 13, 2025 14:42
d2c0451
to
91fcbba
Compare
dianasavvatina
force-pushed
the
wc_errh
branch
from
January 13, 2025 16:15
91fcbba
to
3c2c490
Compare
dianasavvatina
force-pushed
the
wc_errh
branch
from
January 13, 2025 16:22
3c2c490
to
112a0e9
Compare
dianasavvatina
force-pushed
the
wc_errh
branch
from
January 13, 2025 16:46
112a0e9
to
85acc70
Compare
9 tasks
dianasavvatina
force-pushed
the
wc_errh
branch
from
January 13, 2025 17:04
85acc70
to
ca14aab
Compare
dianasavvatina
force-pushed
the
wc_errh
branch
from
January 14, 2025 11:21
ca14aab
to
f79a7b6
Compare
dianasavvatina
force-pushed
the
wc_errh
branch
from
January 14, 2025 15:13
f79a7b6
to
5085be1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Significantly improved error handling:
contract involved by the user.
The implementation follows:
5.1 Error object
Types of changes
Steps to reproduce
code
andmessage
.Sign
and close the request on wallet side. Check that dApp receivedcode
andmessage
about user rejectSend transaction
and close the request on wallet side. Check that dApp receivedcode
andmessage
about user rejectdelegate
twice for the same address. Make sure that dApp receivedcode
,message
anddata
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Error log
Response:
Error log:
Toast:
Error log:
Toast:
Toast:
All necessary data is returned to dApp and the reject message is sent to logs:
Sign:
Send:
Checklist